• jj4211@lemmy.world
    link
    fedilink
    English
    arrow-up
    1
    ·
    17 hours ago

    Just so long as your ultimate pull request is plausibly human viable.

    Have been fighting someone because they submitted a 15,000 line pull request for ‘one’ feature and no one is going to review that mess. I gave a very quick ‘for example’ showing in the first 30 lines of changes that it’s screwing around with stuff that has nothing to do with what the sloperator said they pointed out.

    Now they are complaining that I won’t take code even though Claude audited it and said it is all good…

    (This is work, so I don’t have the luxury of just permanently ignoring them).

    • aksdb@lemmy.world
      link
      fedilink
      English
      arrow-up
      1
      ·
      16 hours ago

      How senior are you? How much senior backing do you have? Close the PR with the comment “unreviewable”. Either they provider smaller chunks, or they can fuck off. If they are unable to prompt properly, that’s on them. They can use Claude all they want, but they should learn how to.

      • jj4211@lemmy.world
        link
        fedilink
        English
        arrow-up
        1
        ·
        1 hour ago

        Yeah, the things is the processes at work are all driven by optimism, “won’t fix” is not an available option for a bug, and “not bothering” isn’t a valid answer to a PR. And both the owner and reporter must agree on any closure.

        So we end up with perma-issues that can’t be closed.

        I can effectively block the PR, but so long as the submitter wants it open… Doesn’t matter how senior I am.